Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix: allow brush with rangeBars #4071

Merged
merged 1 commit into from Oct 27, 2023
Merged

Conversation

davidchateau
Copy link
Contributor

New Pull Request

I believe it's currently not possible to use the 'brush' feature with rangeBars charts. JavaScript raises errors because the code attempts to read fields from null objects (e.g., w.globals.xAxisScale).
I have attempted to implement a clean and minimal fix, closely resembling the existing code. Each change is wrapped within an 'if (w.globals.isRangeBar)' condition to avoid interference with other features.

Fixes
I didn't file an issue, but someone raised the problem earlier this year: https://stackoverflow.com/questions/75618138/a-combination-of-two-rangebar-charts-in-apexcharts-but-brush-chart-does-not-work

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@junedchhipa junedchhipa merged commit 7cdf45a into apexcharts:main Oct 27, 2023
@junedchhipa
Copy link
Contributor

junedchhipa commented Oct 27, 2023

@davidchateau I have merged this.
Can you please create a demo of range-bars with the brush?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants