Skip to content

Commit

Permalink
Added support for testing on PHP 8.3 (#303)
Browse files Browse the repository at this point in the history
* Added support for testing on PHP 8.3

* Fixed one issue
  • Loading branch information
davidbyoung committed Nov 28, 2023
1 parent 4b76f3c commit 7a58989
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 6 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/ci-template.yml
Expand Up @@ -25,6 +25,8 @@ jobs:
include:
- php: '8.2'
stability: prefer-stable
- php: '8.3'
stability: prefer-stable
name: PHP ${{ matrix.php }} - ${{ matrix.stability }}
steps:
- name: Check Out Code
Expand All @@ -43,7 +45,7 @@ jobs:
- name: Run Tests
run: composer phpunit
- name: Run Linter
run: composer phpcs-test
run: PHP_CS_FIXER_IGNORE_ENV=1 composer phpcs-test
- name: Run Psalm Static Analysis
if: inputs.run-psalm == true
run: composer psalm -- --shepherd
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
Expand Up @@ -4,7 +4,7 @@

### Changed

- Nothing
- Added support for PHP 8.3 ([#303](https://github.com/aphiria/aphiria/pull/303))

### Added

Expand Down
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -74,7 +74,7 @@ Full documentation is available at <a href="https://www.aphiria.com" target="_bl

## Requirements

* PHP 8.2
* PHP >= 8.2

## Contributing

Expand Down
6 changes: 3 additions & 3 deletions src/Framework/tests/Net/Binders/RequestBinderTest.php
Expand Up @@ -18,7 +18,7 @@
use Closure;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\TestCase;
use ReflectionProperty;
use ReflectionClass;

class RequestBinderTest extends TestCase
{
Expand All @@ -32,8 +32,8 @@ protected function setUp(): void
protected function tearDown(): void
{
// Make sure to reset the overriding request after each test
$reflectionProperty = new ReflectionProperty(RequestBinder::class, 'overridingRequest');
$reflectionProperty->setValue(null);
$reflectionClass = new ReflectionClass(RequestBinder::class);
$reflectionClass->setstaticpropertyvalue('overridingRequest', null);
}

public function testOverriddenRequestIsUsedIfSpecified(): void
Expand Down

0 comments on commit 7a58989

Please sign in to comment.