Fixed Psalm errors (#145)

aphiria · Aug 1, 2021 · 990cf0d · 990cf0d
1 parent d0cec26
commit 990cf0d
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 9 deletions.
diff --git a/src/Application/src/Configuration/HashTableConfiguration.php b/src/Application/src/Configuration/HashTableConfiguration.php
@@ -93,7 +93,10 @@ public function getValue(string $path): mixed
 
         foreach ($explodedPath as $i => $pathPart) {
             if (!isset($value[$pathPart])) {
-                $fullPathToThisPart = \implode($this->pathDelimiter, \array_slice($explodedPath, 0, $i + 1));
+                $fullPathToThisPart = \implode(
+                    $this->pathDelimiter,
+                    \array_map(static fn (mixed $value) => (string)$value, \array_slice($explodedPath, 0, $i + 1))
+                );
 
                 throw new MissingConfigurationValueException($fullPathToThisPart);
             }

diff --git a/src/Console/src/Output/Formatters/TableFormatter.php b/src/Console/src/Output/Formatters/TableFormatter.php
@@ -69,7 +69,7 @@ public function format(array $rows, array $headers = []): string
                     '%s%s%s%s%s',
                     $this->verticalBorderChar,
                     $this->cellPaddingString,
-                    \implode($this->cellPaddingString . $this->verticalBorderChar . $this->cellPaddingString, $row),
+                    \implode($this->cellPaddingString . $this->verticalBorderChar . $this->cellPaddingString, \array_map(static fn (mixed $value) => (string)$value, $row)),
                     $this->cellPaddingString,
                     $this->verticalBorderChar
                 )

diff --git a/src/Net/src/Http/Headers.php b/src/Net/src/Http/Headers.php
@@ -34,7 +34,7 @@ public function __toString(): string
         $headerString = '';
 
         foreach ($this->hashKeysToKvps as $kvp) {
-            $headerString .= "{$kvp->getKey()}: " . \implode(', ', (array)$kvp->getValue()) . "\r\n";
+            $headerString .= "{$kvp->getKey()}: " . \implode(', ', \array_map(static fn (mixed $value) => (string)$value, (array)$kvp->getValue())) . "\r\n";
         }
 
         return \rtrim($headerString);

diff --git a/src/Net/src/Http/StreamResponseWriter.php b/src/Net/src/Http/StreamResponseWriter.php
@@ -81,7 +81,7 @@ public function writeResponse(IResponse $response): void
                     $this->header("$headerName: $headerValue", false);
                 }
             } else {
-                $this->header("$headerName: " . \implode(', ', (array)$kvp->getValue()));
+                $this->header("$headerName: " . \implode(', ', \array_map(static fn (mixed $value) => (string)$value, (array)$kvp->getValue())));
             }
         }
 

diff --git a/src/Router/tests/Attributes/AttributeRouteRegistrantTest.php b/src/Router/tests/Attributes/AttributeRouteRegistrantTest.php
@@ -54,7 +54,6 @@ public function testRegisteringRouteForNonControllerRegistersNothing(): void
     public function testRegisteringRouteWithAllPropertiesSetCreatesRouteWithAllThosePropertiesSet(): void
     {
         $controller = new class() extends Controller {
-            /** @psalm-suppress ArgumentTypeCoercion https://github.com/vimeo/psalm/issues/4871 */
             #[
                 Get('foo', 'example.com', 'routename', true, ['foo' => 'bar']),
                 RouteConstraint(DummyConstraint::class, ['param'])
@@ -85,7 +84,6 @@ public function route(): void
     public function testRegisteringRouteWithMiddlewareCreatesRouteWithThatMiddleware(): void
     {
         $controller = new class() extends Controller {
-            /** @psalm-suppress ArgumentTypeCoercion https://github.com/vimeo/psalm/issues/4871 */
             #[
                 Get('bar'),
                 Middleware(DummyMiddleware::class, ['foo' => 'bar'])
@@ -111,7 +109,6 @@ public function route(): void
 
     public function testRegisteringRouteWithMiddlewareThatIsInRouteGroupWithMiddlewareCreatesRouteWithBothMiddleware(): void
     {
-        /** @psalm-suppress ArgumentTypeCoercion https://github.com/vimeo/psalm/issues/4871 */
         $controller = new #[Middleware(DummyMiddleware::class, ['foo' => 'bar'])] class() extends Controller
         {
             #[
@@ -142,7 +139,6 @@ public function route(): void
     public function testRegisteringRouteWithMultipleMiddlewareCreatesRouteWithThoseMiddleware(): void
     {
         $controller = new class() extends Controller {
-            /** @psalm-suppress ArgumentTypeCoercion https://github.com/vimeo/psalm/issues/4871 */
             #[
                 Get('bar'),
                 Middleware(DummyMiddleware::class, ['foo' => 'bar']),
@@ -293,7 +289,6 @@ public function routeWithParameters(): void
 
     public function testRegisteringRoutesWithRouteConstraintsAppliesConstraintsToChildRoutes(): void
     {
-        /** @psalm-suppress ArgumentTypeCoercion https://github.com/vimeo/psalm/issues/4871 */
         $controller = new #[RouteConstraint(DummyConstraint::class, ['foo'])] class() extends Controller
         {
             #[Get('')]