Changed default app:serve port to 8080 (#115)

* Updated default port number to 8080 when running locally * Fixed broken unit test
aphiria · Feb 2, 2021 · ddff5f1 · ddff5f1
1 parent 6e07f92
commit ddff5f1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Console/Commands/ServeCommand.php b/src/Console/Commands/ServeCommand.php
@@ -36,7 +36,7 @@ public function __construct(string $routerPath = null)
             [],
             [
                 new Option('domain', OptionTypes::REQUIRED_VALUE, null, 'The domain to run your app at', 'localhost'),
-                new Option('port', OptionTypes::REQUIRED_VALUE, null, 'The port to run your app at', 80),
+                new Option('port', OptionTypes::REQUIRED_VALUE, null, 'The port to run your app at', 8080),
                 new Option('docroot', OptionTypes::REQUIRED_VALUE, null, 'The document root of your app', 'public'),
                 new Option('router', OptionTypes::REQUIRED_VALUE, null, 'The router file for your app', $routerPath)
             ],

diff --git a/tests/Console/Commands/ServeCommandTest.php b/tests/Console/Commands/ServeCommandTest.php
@@ -33,7 +33,7 @@ public function testCorrectValuesAreSetInConstructor(): void
         $this->assertSame('Runs your app locally', $command->description);
         $expectedOptions = [
             new Option('domain', OptionTypes::REQUIRED_VALUE, null, 'The domain to run your app at', 'localhost'),
-            new Option('port', OptionTypes::REQUIRED_VALUE, null, 'The port to run your app at', 80),
+            new Option('port', OptionTypes::REQUIRED_VALUE, null, 'The port to run your app at', 8080),
             new Option('docroot', OptionTypes::REQUIRED_VALUE, null, 'The document root of your app', 'public'),
             new Option('router', OptionTypes::REQUIRED_VALUE, null, 'The router file for your app', 'router')
         ];