Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Settings] Network Fee #36

Merged
merged 1 commit into from Oct 1, 2018
Merged

[Settings] Network Fee #36

merged 1 commit into from Oct 1, 2018

Conversation

crishellco
Copy link
Contributor

Ticket

  • n/a

Changes

  • Add network fee
  • Update numeral.js
  • Fix transaction detail from History

Screenshots

Code Coverage

@crishellco crishellco added the enhancement New feature or request label Oct 1, 2018
@crishellco crishellco self-assigned this Oct 1, 2018
jsolman
jsolman reviewed Oct 1, 2018
View reviewed changes
src/services/network.js
},
},
];

const NETWORK_FEE_OPTIONS = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now still, as it is what we have on desktop, but we really need to support setting fee per K/Byte and support any value instead of powers of 10.

@crishellco crishellco merged commit a6d2e32 into development Oct 1, 2018
@crishellco crishellco deleted the cm/network-fee branch October 1, 2018 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsolman jsolman jsolman approved these changes

@rlucas6130 rlucas6130 Awaiting requested review from rlucas6130

@schaeferCode schaeferCode Awaiting requested review from schaeferCode

Assignees

@crishellco crishellco

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@crishellco @jsolman