Load entire certificate chain from file #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, this looks good! Did you run the tests? |
|
Cool. Ran the tests (as described in the README) and they look good. I've also run Riemann with these new changes, and verified everything is behaving the way I would expect. |
|
Great! I'll cut a new release and you'll be good to go. :) |
|
OK! 1.0.3 out the door. :) |
|
That was super fast - many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reads in a certificate chain (cert + intermediate, etc) instead of just a single certificate. When using intermediate certificates, typically the server will need to present the intermediate along with it's own certificate.
You could also use the same approach for the CA (load multiple root certificates from a single file) but at least in our environment we want to trust a very specific root certificate, so I didn't look at that.
I am relatively new to Clojure (especially wrt Java interop), so please forgive me for any blaring mistakes. 馃榾