refactor: move extraInformation to meta #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The *Params datatypes have a meta field that can be filled with any value as necesarry for the dataprovider, see UpdateParams here https://github.com/marmelab/react-admin/blob/master/packages/ra-core/src/types.ts#L189-L194 It's better to use this value instead of polluting the data object
|
This is a priority also because it is only removed before sending in the hydra dataProvider. With OpenAPI, extraInformation is sent with the request which is then rejected on the server side because of the additonal field. |
PawelSuwinski
requested review from
PawelSuwinski
and removed request for
PawelSuwinski
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The *Params datatypes have a meta field that can be filled with any value as necesarry for the dataprovider, see UpdateParams here https://github.com/marmelab/react-admin/blob/master/packages/ra-core/src/types.ts#L189-L194
It's better to use this value instead of polluting the data object