chore: make the development process easier with Storybook #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…never read in check build
…ile /srv/app/.storybook/test-runner-jest.ts
slax57
requested changes
Apr 9, 2024
slax57
reviewed
Apr 9, 2024
dunglas
requested changes
Apr 18, 2024
Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>
soyuka
reviewed
May 2, 2024
|
|
||
| CMD ["yarn", "serve"] | ||
| RUN set -eux; \ | ||
| yarn playwright install --with-deps && yarn cache clean |
There was a problem hiding this comment.
should we install this on the dev container as well? then add instructions on how to run that inside docker?
soyuka
reviewed
May 2, 2024
api/config/packages/cache.yaml
Outdated
|
|
||
| # Namespaced pools use the above "app" backend by default | ||
| #pools: | ||
| #my.dedicated.cache: null |
There was a problem hiding this comment.
can you remove the comments in this file?
soyuka
reviewed
May 2, 2024
| @@ -0,0 +1,62 @@ | |||
| monolog: | |||
There was a problem hiding this comment.
I wish we could remove this, I'll see that in another patch
adguernier
changed the title
authProvider works
adguernier
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to validate that passing a React-admin
authProviderto the<HydraAdmin>component as a prop works well.It adds some Stories and interactions tests running thanks to Storybook and Playwright.
You might read the CONTRIBUTING.md first to know how to test this PR.
Todo:
authProviderprop