fix: header defaults in Caddyfile must be in separate handlers #1893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discussion in caddyserver/caddy#4130 brought this up. There's a bit of a gotcha here, in that having two `?Field` headers will append each to the `Require` response matcher, so those header fields will only be set if _both_ are not present in the response. If one is present (e.g. `Link` is in the response) then neither are set. Using separate header handlers solves this because they will use their own handlers, and therefore separate response matchers.
dunglas
approved these changes
Apr 24, 2021
|
Thanks @francislavoie! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion in caddyserver/caddy#4130 brought this up.
There's a bit of a gotcha here, in that having two
?Fieldheaders will append each to theRequireresponse matcher, so those header fields will only be set if both are not present in the response. If one is present (e.g.Linkis in the response) then neither are set.Using separate header handlers solves this because they will use their own handlers, and therefore separate response matchers.
This is just a followup to #1879 to fix this non-obvious behaviour.