Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Use Docker Composer For update-deps.sh #2635

Conversation

tstrijdhorst
Copy link

@tstrijdhorst tstrijdhorst commented Feb 15, 2024

Running update-deps.sh failed for me since I don't have PHP or composer installed on my host system.
The other commands regarding composer are executed within the context of the php container and using that
for the recipe updates will keep everything contained to the docker environment.

Q A
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@tstrijdhorst tstrijdhorst marked this pull request as ready for review February 15, 2024 14:08
@dunglas
Copy link
Member

dunglas commented Feb 15, 2024

IIRC, we did that because Flex needs to access the Git repository and it isn't mounted as a volume in Docker containers (only api/ is mounted in the php container).
Your patch will not work because api/ doesn't exist in the container.

That being said, this script is mostly intended for API Platform maintainers (we may remove it from the archives at some point). Users are encouraged to use https://github.com/coopTilleuls/template-sync instead, which does much more than update the dependencies (it also updates the various config files).

@tstrijdhorst
Copy link
Author

Oh my, I could have sworn I saw it work but it definitely does not. Must be end of the day vibes, my apologies.

Thank you for taking the time to reply and pointing me in the right direction 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants