Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ld+json encoding #2638

Merged
merged 1 commit into from Feb 18, 2024
Merged

feat: add ld+json encoding #2638

merged 1 commit into from Feb 18, 2024

Conversation

vasilvestre
Copy link
Contributor

@vasilvestre vasilvestre commented Feb 18, 2024

I'm not sure if this is a fix or new feature

Q A
Branch? main
Tickets Closes #2637
License MIT

@dunglas
Copy link
Member

dunglas commented Feb 18, 2024

I fixed this in Caddy directly: caddyserver/caddy#6081

Maybe can we just wait for a new Caddy tag?

@vasilvestre
Copy link
Contributor Author

I fixed this in Caddy directly: caddyserver/caddy#6081

Maybe can we just wait for a new Caddy tag?

Depending of how long Caddy takes to tag, maybe it's better to merge and remove the configuration when it's done ? Or you may comment the issue so people could find a workaround until the next apip release

@dunglas
Copy link
Member

dunglas commented Feb 18, 2024

Let's merge for now!

@dunglas dunglas merged commit da6b2c0 into api-platform:main Feb 18, 2024
2 checks passed
@dunglas
Copy link
Member

dunglas commented Feb 18, 2024

Thank you Valentin

@vasilvestre vasilvestre deleted the patch-1 branch February 18, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ld-json not encoded by Caddyfile
2 participants