Merge pull request #4671 from soyuka/feat/upgrade-command

feat: upgrade script, remove rector
api-platform · Mar 10, 2022 · 09f1ec9 · 09f1ec9
2 parents dee2868 + 4ce0382
commit 09f1ec9
Show file tree

Hide file tree

Showing 64 changed files with 1,281 additions and 2,441 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -779,7 +779,7 @@ jobs:
         run: vendor/bin/behat --out=std --format=progress --profile=default --no-interaction
 
   behat-rector-upgrade:
-    name: Behat (PHP ${{ matrix.php }}) (Rector)
+    name: Behat (PHP ${{ matrix.php }}) (upgrade script)
     runs-on: ubuntu-latest
     timeout-minutes: 20
     strategy:
@@ -808,16 +808,15 @@ jobs:
           restore-keys: ${{ runner.os }}-composer-
       - name: Update project dependencies
         run: composer update --no-interaction --no-progress --ansi
-      - name: Require Symfony components and Rector dependencies
-        run: composer require symfony/uid rector/rector:0.12.5 --dev --no-interaction --no-progress --ansi
+      - name: Require Symfony components
+        run: composer require symfony/uid --dev --no-interaction --no-progress --ansi
       - name: Install PHPUnit
         run: vendor/bin/simple-phpunit --version
       - name: Clear test app cache
         run: rm -Rf tests/Fixtures/app/var/cache/*
-      - name: Convert annotations to attributes
+      - name: Convert metadata to API Platform 3
         run: |
-          tests/Fixtures/app/console api:rector:upgrade tests/Fixtures/TestBundle/Entity --transform-apisubresource -s  -n
-          tests/Fixtures/app/console api:rector:upgrade tests/Fixtures/TestBundle/Entity --annotation-to-api-resource -s -n
+            tests/Fixtures/app/console api:upgrade-resource -f
       - name: Clear test app cache
         run: rm -Rf tests/Fixtures/app/var/cache/*
       - name: Run Behat tests
@@ -857,7 +856,7 @@ jobs:
         continue-on-error: true
 
   behat-rector-upgrade-mongodb:
-    name: Behat (PHP ${{ matrix.php }}) (Rector / MongoDB)
+    name: Behat (PHP ${{ matrix.php }}) (upgrade script / MongoDB)
     runs-on: ubuntu-latest
     env:
       APP_ENV: mongodb
@@ -892,16 +891,15 @@ jobs:
           restore-keys: ${{ runner.os }}-composer-
       - name: Update project dependencies
         run: composer update --no-interaction --no-progress --ansi
-      - name: Require Symfony components and Rector dependencies
-        run: composer require symfony/uid rector/rector:0.12.5 --dev --no-interaction --no-progress --ansi
+      - name: Require Symfony components
+        run: composer require symfony/uid --dev --no-interaction --no-progress --ansi
       - name: Install PHPUnit
         run: vendor/bin/simple-phpunit --version
       - name: Clear test app cache
         run: rm -Rf tests/Fixtures/app/var/cache/*
-      - name: Convert annotations to attributes
+      - name: Convert metadata to API Platform 3
         run: |
-          tests/Fixtures/app/console api:rector:upgrade tests/Fixtures/TestBundle/Document --transform-apisubresource -s -n
-          tests/Fixtures/app/console api:rector:upgrade tests/Fixtures/TestBundle/Document --annotation-to-api-resource -s -n
+            tests/Fixtures/app/console api:upgrade-resource -f
       - name: Clear test app cache
         run: rm -Rf tests/Fixtures/app/var/cache/*
       - name: Run Behat tests

diff --git a/src/Core/Bridge/Rector/Resolver/OperationClassResolver.php b/src/Core/Bridge/Rector/Resolver/OperationClassResolver.php
diff --git a/src/Core/Bridge/Rector/Rules/AbstractAnnotationToAttributeRector.php b/src/Core/Bridge/Rector/Rules/AbstractAnnotationToAttributeRector.php