Add CollectionResolverFactory test to cover a field not being prese…

…nt in the source.
api-platform · Mar 30, 2021 · 4bc3c48 · 4bc3c48
1 parent 4558ab9
commit 4bc3c48
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 1 deletion.
diff --git a/tests/Fixtures/TestBundle/Document/SecuredDummy.php b/tests/Fixtures/TestBundle/Document/SecuredDummy.php
@@ -217,7 +217,6 @@ public function setRelatedDummy(RelatedDummy $relatedDummy)
         $this->relatedDummy = $relatedDummy;
     }
 
-
     public function addRelatedSecuredDummy(RelatedSecuredDummy $relatedSecuredDummy)
     {
         $this->relatedSecuredDummies->add($relatedSecuredDummy);

diff --git a/tests/GraphQl/Resolver/Factory/CollectionResolverFactoryTest.php b/tests/GraphQl/Resolver/Factory/CollectionResolverFactoryTest.php
@@ -110,6 +110,36 @@ public function testResolve(): void
         $this->assertSame($serializeStageData, ($this->collectionResolverFactory)($resourceClass, $rootClass, $operationName)($source, $args, null, $info));
     }
 
+    public function testResolveFieldNotInSource(): void
+    {
+        $resourceClass = 'stdClass';
+        $rootClass = 'rootClass';
+        $operationName = 'collection_query';
+        $source = ['source'];
+        $args = ['args'];
+        $info = $this->prophesize(ResolveInfo::class)->reveal();
+        $info->fieldName = 'testField';
+        $resolverContext = ['source' => $source, 'args' => $args, 'info' => $info, 'is_collection' => true, 'is_mutation' => false, 'is_subscription' => false];
+
+        $readStageCollection = [new \stdClass()];
+        $this->readStageProphecy->__invoke($resourceClass, $rootClass, $operationName, $resolverContext)->shouldNotBeCalled();
+
+        $this->securityStageProphecy->__invoke($resourceClass, $operationName, $resolverContext + [
+            'extra_variables' => [
+                'object' => $readStageCollection,
+            ],
+        ])->shouldNotBeCalled();
+        $this->securityPostDenormalizeStageProphecy->__invoke($resourceClass, $operationName, $resolverContext + [
+            'extra_variables' => [
+                'object' => $readStageCollection,
+                'previous_object' => $readStageCollection,
+            ],
+        ])->shouldNotBeCalled();
+
+        // Null should be returned if the field isn't in the source - as its lack of presence will be due to @ApiProperty security stripping unauthorized fields
+        $this->assertNull(($this->collectionResolverFactory)($resourceClass, $rootClass, $operationName)($source, $args, null, $info));
+    }
+
     public function testResolveNullSource(): void
     {
         $resourceClass = 'stdClass';