fix #3980 DataPersister supports called without context

api-platform · Jan 25, 2021 · 8426f0a · 8426f0a
1 parent 4b293b0
commit 8426f0a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/src/Bridge/Symfony/Bundle/DataPersister/TraceableChainDataPersister.php b/src/Bridge/Symfony/Bundle/DataPersister/TraceableChainDataPersister.php
@@ -73,7 +73,7 @@ private function tracePersisters($data, array $context = [])
         $found = false;
         foreach ($this->persisters as $persister) {
             if (
-                ($this->persistersResponse[\get_class($persister)] = $found ? false : $persister->supports($data))
+                ($this->persistersResponse[\get_class($persister)] = $found ? false : $persister->supports($data, $context))
                 &&
                 !($persister instanceof ResumableDataPersisterInterface && $persister->resumable()) && !$found
             ) {

diff --git a/tests/Bridge/Symfony/Bundle/DataPersister/TraceableChainDataPersisterTest.php b/tests/Bridge/Symfony/Bundle/DataPersister/TraceableChainDataPersisterTest.php
@@ -60,6 +60,16 @@ public function testRemove($persister, $expected)
         $this->assertSame($expected, array_values($result));
     }
 
+    public function testSupports() {
+        $context = ['ok' => true];
+        $persister = $this->prophesize(DataPersisterInterface::class);
+        $persister->supports('', $context)->willReturn(true)->shouldBeCalled();
+        $chain = new ChainDataPersister([$persister->reveal()]);
+        $persister->persist('', $context)->shouldBeCalled();
+        $dataPersister = new TraceableChainDataPersister($chain);
+        $dataPersister->persist('',$context);
+    }
+
     public function dataPersisterProvider(): iterable
     {
         yield [
@@ -163,7 +173,7 @@ public function persist($data)
                     public function remove($data)
                     {
                     }
-                },
+                }
             ]),
             [true, false, true],
         ];