fix(doctrine): denormalization of properties with embeds many which o…

…mit target document directive
api-platform · Jun 10, 2021 · d5b8e65 · d5b8e65
1 parent e32b4e8
commit d5b8e65
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 0 deletions.
diff --git a/src/Bridge/Doctrine/MongoDbOdm/PropertyInfo/DoctrineExtractor.php b/src/Bridge/Doctrine/MongoDbOdm/PropertyInfo/DoctrineExtractor.php
@@ -65,6 +65,10 @@ public function getTypes($class, $property, array $context = [])
         if ($metadata->hasAssociation($property)) {
             $class = $metadata->getAssociationTargetClass($property);
 
+            if (null === $class) {
+                return null;
+            }
+
             if ($metadata->isSingleValuedAssociation($property)) {
                 $nullable = $metadata instanceof MongoDbClassMetadata && $metadata->isNullable($property);
 

diff --git a/tests/Bridge/Doctrine/MongoDbOdm/PropertyInfo/DoctrineExtractorTest.php b/tests/Bridge/Doctrine/MongoDbOdm/PropertyInfo/DoctrineExtractorTest.php
@@ -74,6 +74,7 @@ public function testTestGetPropertiesWithEmbedded(): void
                 'id',
                 'embedOne',
                 'embedMany',
+                'embedManyOmittingTargetDocument',
             ],
             $this->createExtractor()->getProperties(DoctrineWithEmbedded::class)
         );
@@ -197,6 +198,18 @@ public function testGeneratedValueNotWritable()
         $this->assertNull($extractor->isReadable(DoctrineGeneratedValue::class, 'foo'));
     }
 
+    public function testGetTypesWithEmbedManyOmittingTargetDocument(): void
+    {
+        $expectedTypes = null;
+
+        $actualTypes = $this->createExtractor()->getTypes(
+            DoctrineWithEmbedded::class,
+            'embedManyOmittingTargetDocument'
+        );
+
+        self::assertEquals($expectedTypes, $actualTypes);
+    }
+
     private function createExtractor(): DoctrineExtractor
     {
         $config = DoctrineMongoDbOdmSetup::createAnnotationMetadataConfiguration([__DIR__.\DIRECTORY_SEPARATOR.'Fixtures'], true);

diff --git a/tests/Bridge/Doctrine/MongoDbOdm/PropertyInfo/Fixtures/DoctrineWithEmbedded.php b/tests/Bridge/Doctrine/MongoDbOdm/PropertyInfo/Fixtures/DoctrineWithEmbedded.php
@@ -39,4 +39,9 @@ class DoctrineWithEmbedded
      * @EmbedMany(targetDocument=DoctrineEmbeddable::class)
      */
     protected $embedMany;
+
+    /**
+     * @EmbedMany
+     */
+    protected $embedManyOmittingTargetDocument;
 }