Use snake case for pagination type (#3614)

api-platform · Jun 19, 2020 · e7dad31 · e7dad31
1 parent ccdbb5f
commit e7dad31
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/src/DataProvider/Pagination.php b/src/DataProvider/Pagination.php
@@ -215,7 +215,7 @@ public function getGraphQlPaginationType(string $resourceClass, string $operatio
             return 'cursor';
         }
 
-        return (string) $resourceMetadata->getGraphqlAttribute($operationName, 'paginationType', 'cursor', true);
+        return (string) $resourceMetadata->getGraphqlAttribute($operationName, 'pagination_type', 'cursor', true);
     }
 
     /**

diff --git a/tests/Fixtures/TestBundle/Document/FooDummy.php b/tests/Fixtures/TestBundle/Document/FooDummy.php
@@ -26,7 +26,7 @@
  *         "order"={"dummy.name"}
  *     },
  *     graphql={
- *         "collection_query"={"paginationType"="page"}
+ *         "collection_query"={"pagination_type"="page"}
  *     }
  * )
  * @ODM\Document

diff --git a/tests/Fixtures/TestBundle/Entity/FooDummy.php b/tests/Fixtures/TestBundle/Entity/FooDummy.php
@@ -26,7 +26,7 @@
  *         "order"={"dummy.name"}
  *     },
  *     graphql={
- *         "collection_query"={"paginationType"="page"}
+ *         "collection_query"={"pagination_type"="page"}
  *     }
  * )
  * @ORM\Entity

diff --git a/tests/GraphQl/Type/FieldsBuilderTest.php b/tests/GraphQl/Type/FieldsBuilderTest.php
@@ -335,7 +335,7 @@ public function collectionQueryFieldsProvider(): array
                     ],
                 ],
             ],
-            'collection with page-based pagination enabled' => ['resourceClass', (new ResourceMetadata('ShortName', null, null, null, null, ['paginationType' => 'page']))->withGraphql(['action' => ['filters' => ['my_filter']]]), 'action', [], $graphqlType = GraphQLType::listOf(new ObjectType(['name' => 'collection'])), $resolver = function () {
+            'collection with page-based pagination enabled' => ['resourceClass', (new ResourceMetadata('ShortName', null, null, null, null, ['pagination_type' => 'page']))->withGraphql(['action' => ['filters' => ['my_filter']]]), 'action', [], $graphqlType = GraphQLType::listOf(new ObjectType(['name' => 'collection'])), $resolver = function () {
             },
                 [
                     'actionShortNames' => [

diff --git a/tests/GraphQl/Type/TypeBuilderTest.php b/tests/GraphQl/Type/TypeBuilderTest.php
@@ -436,7 +436,7 @@ public function testCursorBasedGetResourcePaginatedCollectionType(): void
             null,
             null,
             null,
-            ['paginationType' => 'cursor']
+            ['pagination_type' => 'cursor']
         ));
 
         /** @var ObjectType $resourcePaginatedCollectionType */
@@ -498,7 +498,7 @@ public function testPageBasedGetResourcePaginatedCollectionType(): void
             null,
             null,
             null,
-            ['paginationType' => 'page']
+            ['pagination_type' => 'page']
         ));
 
         /** @var ObjectType $resourcePaginatedCollectionType */