Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering nested properties with a name converter won't work reliably #2893

Closed
bendavies opened this issue Jul 1, 2019 · 0 comments
Closed
Assignees
Milestone

Comments

@bendavies
Copy link
Contributor

Introduced in:
#2751

Example:

With CamelCaseToSnakeCaseNameConverter configured

Specify a filter such as:

 * @ApiFilter(SearchFilter::class, properties={"customer.fooBar": "exact"})

a client should be able to request:

GET /resource/?customer.foo_bar=baz

but the property being filtered will be converted to customer_FooBar in AbstractContextAwareFilter, so will obviously fail to filter the nested property correctly.

@dunglas dunglas added this to the 2.5.0 milestone Jul 1, 2019
@antograssiot antograssiot self-assigned this Jul 2, 2019
@dunglas dunglas closed this as completed Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants