Add support for name converter in filters #2751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antograssiot
force-pushed
the
filter-name-converter
branch
from
e132f29
to
646bd37
Compare
bendavies
reviewed
Apr 23, 2019
|
awesome work! |
soyuka
reviewed
Apr 23, 2019
antograssiot
commented
Apr 23, 2019
|
Do not merge that yet, I've just remembered that there are no tests for GraphQL yet. |
dunglas
approved these changes
May 6, 2019
|
@antograssiot could we merge (pls rebase :D) this and do the graphql support in another pr? |
|
Sure I'll rebase and merge tonight or tomorrow. GraphQl support is already in another PR anyway |
antograssiot
force-pushed
the
filter-name-converter
branch
from
3149282
to
74692f2
Compare
|
GraphQL support will land with #2765 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #2377, which I think is more complete and more accurate as some filters were not properly covered.
The Group Filter is not supposed to be updated I think
I've added Behat tests against the schema as we do usually but also plain JSON content. I've made sure that the schemas are actually really validating what I'm looking for but at the end it is way more verbose, and I'm not sure it will be easier to maintain. I'll of course leave only a single version of the test, let me know what's your prefered one.
I've been checking and it works correctly with Swagger UI/ReDoc
TODO
Thanks for your feedback
cc @bendavies @soullivaneuh