Remove nonsensical "child inherited" metadata #3273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
phpstan error will be fixed by #3274 |
soyuka
reviewed
Nov 18, 2019
soyuka
reviewed
Nov 18, 2019
teohhanhui
force-pushed
the
fix/remove-child-inherited-metadata
branch
from
6ecb5af
to
22a0846
Compare
|
can you rebase, let's merge this :) |
teohhanhui
force-pushed
the
fix/remove-child-inherited-metadata
branch
from
22a0846
to
be5752f
Compare
|
Rebased. 😄 |
|
phpstan failure seems unrelated... Looks like it's caused by the release of Symfony 5.0 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #3232. Targeting
masterbecause it's considered risky to go into a patch release.