fix InheritedPropertyMetadataFactory to build correctly the metadata #2869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 19, 2019 16:44
…inherited from the parent classes
|
This is a really hot path haha, I'm not sure that it's the correct fix, maybe that #2861 is related? |
|
It fixes metadata for classes that inherit from some other class. |
|
When can I expect this fix to be released? |
|
Just tested this patch with my current project and it seems to fix my issues with single table inheritances :) |
|
This is obsolete after #3273. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The InheritedPropertyMetadataFactory is supposed to build the metadata of all the inherited properties of a class from its parents. This was not working because of a mistake on the
is_subclass_ofcheck.The related test was always passing because of a wrong mock. I fixed that, too.
There are some related issues that have been fixed in the past but that were probably still actual now, such as #1071 and #615