Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenAPI BC Layer #4005

Closed
soyuka opened this issue Feb 1, 2021 · 0 comments
Closed

OpenAPI BC Layer #4005

soyuka opened this issue Feb 1, 2021 · 0 comments
Milestone
2.6.2

Comments

@soyuka
Copy link
Member

soyuka commented Feb 1, 2021

  • Add a flag openapi_bc_layer that uses the new normalizer + the OpenAPI Factory
  • Inject the new normalizer in the old one (DocumentationNormalizer):
    • if the denormalized object is an OpenApi we use the new normalizer
    • if not trigger a deprecation + advice to use the OpenApiFactory

This allows users to still decorate the old service + adds a deprecation
@soyuka soyuka added this to the 2.6.2 milestone Feb 1, 2021
soyuka added a commit to soyuka/core that referenced this issue Feb 2, 2021
@soyuka
Fix api-platform#4005 BC layer for openapi normalizer
9e777e3
@soyuka soyuka mentioned this issue Feb 2, 2021
Merged
soyuka added a commit to soyuka/core that referenced this issue Feb 2, 2021
@soyuka
Fix api-platform#4005 BC layer for openapi normalizer
9d44fc4
soyuka added a commit to soyuka/core that referenced this issue Feb 2, 2021
@soyuka
Fix api-platform#4005 BC layer for openapi normalizer
3c4a26b
soyuka added a commit that referenced this issue Feb 3, 2021
@soyuka
Fix #4005 BC layer for openapi normalizer (#4016)
c46f6fb 
* Fix #4005 BC layer for openapi normalizer

* whoops

* whoops

* whoops

* whoops

* Review

* Review

* we have the bc layer covered

* alright now

* improve message
@soyuka soyuka closed this as completed Feb 3, 2021
cacahouwete pushed a commit to cacahouwete/core that referenced this issue Feb 8, 2021
@soyuka @cacahouwete
Fix api-platform#4005 BC layer for openapi normalizer (api-platform#4016
edbb19d 
)

* Fix api-platform#4005 BC layer for openapi normalizer

* whoops

* whoops

* whoops

* whoops

* Review

* Review

* we have the bc layer covered

* alright now

* improve message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.2
Development

No branches or pull requests
1 participant
@soyuka