DISABLE_TYPE_ENFORCEMENT is ignored for non-scalar properties

[emomaliev]

I'm trying to disable type enforcement so I don't get type errors on nullable=false properties.
Instead, I want to see error messages from Assert\NotBlank, Assert\NotNull, etc.

#[ApiResource(
    operations: [
        new Post(
            denormalizationContext: [
                'disable_type_enforcement' => true,
                'collect_denormalization_errors' => true
            ],
        ),
    ],
 )]
class Entity
{
 
    #[ORM\ManyToOne]
    #[ORM\JoinColumn(nullable: false)]
    #[Assert\NotBlank()]
    private ?Brand $brand = null;

    public function getBrand(): ?Brand
    {
        return $this->brand;
    }
    
   public function setBrand(?Brand $brand): void
    {
        $this->brand = $brand;
    }

}

My request:

POST: 
{
  brand: null
}

Actual answer:

{
   "violations":[
      {
         "propertyPath":"brand",
         "message":"This value should be of type array|string.",
         "code":"0"
      }
}

Expected response:

{
   "violations":[
      {
         "propertyPath":"brand",
         "message":"This value should not be blank.",
         "code":"0"
      }
}

As you can see from the actual answer DISABLE_TYPE_ENFORCEMENT does not work for any objects. I have tested it for relations and enum classes (Works for only scalar types).

After researching the problem, I found that in properties with the Object type, we simply do not get to this condition.

core/src/Serializer/AbstractItemNormalizer.php

Lines 843 to 845 in 7a1d351

	if ($context[static::DISABLE_TYPE_ENFORCEMENT] ?? false) {
	return $value;
	}

What do you think about this? Maybe this was expected behavior for you?

This issue has also been mentioned here: #1786

[felipyamorim]

I made a workaround using composer to replace a snippet of code from the AbstractItemNormalizer class.

    "scripts": {
        "post-autoload-dump": [
            "sed -i 's/null === \\$value && \\$type->isNullable()/null === \\$value \\&\\& (\\$type->isNullable() \\|\\| \\$context[static::DISABLE_TYPE_ENFORCEMENT] \\?\\? false)/g' vendor/api-platform/core/src/Serializer/AbstractItemNormalizer.php"
        ],
    }

Same solution as suggested in a previous issue #4250

It's not ideal, but it fixes the problem temporarily. Soon I will make a pull request.

[soyuka]

can you try my patch at #5593 ?

[felipyamorim]

@soyuka thank you for the fix.