PHP Inspect Extended fix #1572
Merged
PHP Inspect Extended fix #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jewome62
force-pushed
the
php-inspect-extended
branch
2 times, most recently
from
436f4f8
to
edd0369
Compare
jewome62
force-pushed
the
php-inspect-extended
branch
from
edd0369
to
da52ae7
Compare
1 task
dunglas
approved these changes
Dec 19, 2017
soyuka
approved these changes
Dec 19, 2017
|
@jewome62 yes I know the whys and what (though thx for the link it's interesting - /e I starred it a while ago haha). Just that we already discussed it last year IIRC and we didn't merge it. Good to know we're moving forward that's all :). |
|
Only some functions can be optimized. A PHP CS Fixer rule to replace only those ones is planned IIRC. |
|
Thanks @jewome62 ! |
Merged
hoangnd25
pushed a commit
to hoangnd25/core
that referenced
this pull request
Feb 23, 2018
PHP Inspect Extended fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some suggestion from PHP Inpector Extended into PHPStorm