Add validation for GraphQL mutations #1604
Conversation
src/Validator/ValidatorInterface.php
Outdated
| * Validates an item. | ||
| * | ||
| * @param object $data | ||
| * @param array $contexy |
| * Validates an item. | ||
| * | ||
| * @param object $data | ||
| * @param array $context |
| private function validate($item, ResolveInfo $info, ResourceMetadata $resourceMetadata, string $operationName = null) | ||
| { | ||
| if (null === $this->validator) { | ||
| return; |
There was a problem hiding this comment.
We don't want to warn the user if there is no validator?
There was a problem hiding this comment.
No (we would just make this property not nullable otherwise), it allows to create micro-frameworks on top of API Platform and it mimics the behavior of the ValidateListener (which is optional).
| /** | ||
| * @expectedException \ApiPlatform\Core\Bridge\Symfony\Validator\Exception\ValidationException | ||
| */ | ||
| public function testInvalid() |
There was a problem hiding this comment.
We wouldn't be able to share much code.
| return; | ||
| } | ||
|
|
||
| $data = $event->getControllerResult(); |
There was a problem hiding this comment.
@dunglas consider validating controller argument data instead of controller result. We cann't put some logic inside controller now because request data is not validated yet.
There was a problem hiding this comment.
I'm not sure to understand, the validation occurs after the execution of the controller.
There was a problem hiding this comment.
If you need to validate the data before executing your logic, just inject ValidatorInterface in your controller and call it.
There was a problem hiding this comment.
I think it's related to this: #1590
There was a problem hiding this comment.
yes, @alanpoulain is right. IMHO validating input data before controller execution is much logical.
There was a problem hiding this comment.
Changing this would be a big BC break and will provide less flexibility. IMO the data must be valid before being persisted, but after the custom logic has been executed.
|
👏 |
* Add validation for GraphQL mutations
Validate data during GraphQL mutations. Also includes a refactoring of the validation system.
TODO: