Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Composer] Sort packages #1606

Merged
merged 1 commit into from
Dec 26, 2017
Merged

[Composer] Sort packages #1606

merged 1 commit into from
Dec 26, 2017

Conversation

lyrixx
Copy link
Contributor

@lyrixx lyrixx commented Dec 26, 2017

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

dunglas
dunglas approved these changes Dec 26, 2017
View reviewed changes
Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you target 2.0 so we'll not have to deal with conflicts when merging branches?

@lyrixx lyrixx changed the base branch from master to 2.0 December 26, 2017 13:18
@lyrixx
Copy link
Contributor Author

lyrixx commented Dec 26, 2017

Et Voilà!

@dunglas dunglas merged commit 8c24b71 into api-platform:2.0 Dec 26, 2017
@dunglas
Copy link
Member

dunglas commented Dec 26, 2017

Thanks Grégoire!

@lyrixx lyrixx deleted the sort-packages branch December 26, 2017 13:35
hoangnd25 pushed a commit to hoangnd25/core that referenced this pull request Feb 23, 2018
@dunglas
Merge pull request api-platform#1606 from lyrixx/sort-packages
dbf3eda 
[Composer] Sort packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lyrixx @dunglas