hal collection links should have a href property

[bendavies]

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no?
Deprecations?	no
Tests pass?	yes
Fixed tickets
License	MIT
Doc PR

It seems to me that json hal links for collections where missing the href property:
https://tools.ietf.org/html/draft-kelly-json-hal-08#section-5.1

[dunglas]

Good catch.

We should also validate the produced HAL output using http://hyperschema.org/mediatypes/hal. As we do for Swagger and JSONAPI.

[bendavies]

@dunglas happy to take a look. can you point me towards what is done currently for swagger and jsonapi?

[soyuka]

@dunglas happy to take a look. can you point me towards what is done currently for swagger and jsonapi?

1. https://github.com/api-platform/core/blob/master/.travis.yml#L43 we install swagger-cli
2. https://github.com/api-platform/core/blob/master/.travis.yml#L56 we launch a swagger-validate command on an extracted JSON file that comes from a symfony command that you can find here

[bendavies]

@dunglas i think I've done what you wanted. Additionally, schema validation was completely broken (not validating at all) in the jsonapi features/context, so I've fixed that.

[dunglas]

Awesome

[meyerbaptiste]

This makes me think that it might be nice to have a script to update our JSON Schema files from:

• https://raw.githubusercontent.com/json-api/json-api/gh-pages/schema
• https://raw.githubusercontent.com/smizell/hyperschema.org/master/src/mediatypes/hal.json

[meyerbaptiste]

Good catch!

[meyerbaptiste]

Oops?

[bendavies]

doh

[dunglas]

Thank you very much @bendavies!