Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: missing throws doc property in the ReadListener #1821

Closed
wants to merge 1 commit into from
Closed

meta: missing throws doc property in the ReadListener #1821

wants to merge 1 commit into from

Conversation

Simperfit
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Missing throws property on the phpdoc.

@Simperfit Simperfit force-pushed the meta/missing-throws-doc-property branch 2 times, most recently from 23626e9 to 34eb41f Compare April 6, 2018 12:58
@soyuka
Copy link
Member

soyuka commented Apr 6, 2018

php-cs-fixer

meyerbaptiste
meyerbaptiste requested changes Apr 6, 2018
View reviewed changes
Copy link
Member

@meyerbaptiste meyerbaptiste left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want this? I am in favor of only annotating exceptions that are explicitly thrown in our methods.

@Simperfit
Copy link
Contributor Author

It is thrown at this point and it's not catched, it's possible to have the exception in here.

@Simperfit Simperfit force-pushed the meta/missing-throws-doc-property branch from 34eb41f to 088c005 Compare April 6, 2018 13:44
@meyerbaptiste
Copy link
Member

So, you have to do the same for the 425 other places:

capture d ecran 2018-04-06 a 15 45 52

@Simperfit
Copy link
Contributor Author

If we agree on this, I will do it, it seems better to me IMHO.

@soyuka
Copy link
Member

soyuka commented Apr 6, 2018

Do we really want this? I am in favor of only annotating exceptions that are explicitly thrown in our methods.

👍 I don't see any advantage

@Simperfit
Copy link
Contributor Author

Than ok ;) we can close this

@Simperfit Simperfit closed this Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meyerbaptiste meyerbaptiste meyerbaptiste requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Simperfit @soyuka @meyerbaptiste