Reorder normalizers (tiny perf improvement) #1906
Closed
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dunglas
commented
Apr 30, 2018
dunglas
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
|
Does this mean a perf improvement for GraphQL at the expense of JSON API? Not that I disagree with it. 😆 |
|
Oops. The build failed on CircleCI because we haven't merged 2.2 back into master. |
|
Yes, but only if you enable both. We advertise mainly JSONLD and GraphQL, IMO they must be the ones privilegied. With the new improvements in Synfony, the improvement will be less significant (because the number of calls to supportsNormalization will be reduced a lot). |
Simperfit
approved these changes
Apr 30, 2018
|
Needs a rebase. |
soyuka
added a commit
that referenced
this pull request
Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.