Revert merge master into 2.2 #1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was an accident. Let us undo the mess.
|
159 files changed 😱 😅 |
19 tasks
|
Travis build almost completed on my repo: https://travis-ci.org/teohhanhui/api-platform-core/builds/374012816 It should be fine. 😃 |
|
Oh yeah ❤️ thanks a lot @teohhanhui |
|
❤️
…On Wed, 2 May 2018 at 18:15, Antoine Bluchet ***@***.***> wrote:
Oh yeah ❤️ thanks a lot @teohhanhui <https://github.com/teohhanhui>
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1924 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAxHEV5tknxG9DQTHm_daoLecFsg3RUlks5tuemdgaJpZM4TvxAb>
.
|
|
Thank you very much for handling this!! |
|
@soyuka suggested that I write a blog post about it. Maybe we could make it a post mortem analysis? And how we could prevent this from happening again... 😂 |
|
would be great! |
|
Definitely! It would be a nice one. Just the fact I've lost ~3 hours going to the wrong direction shows it definitely deserves a blog post (it would have saved me some time hehe) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see #1923 for how it's done.