feature: add a way to always include null in the date filter #1928
Conversation
| @@ -33,6 +33,7 @@ class DateFilter extends AbstractContextAwareFilter | |||
| const EXCLUDE_NULL = 'exclude_null'; | |||
| const INCLUDE_NULL_BEFORE = 'include_null_before'; | |||
| const INCLUDE_NULL_AFTER = 'include_null_after'; | |||
| const ALWAYS_INCLUDE_NULL = 'always_include_null'; | |||
There was a problem hiding this comment.
INCLUDE_NULL only maybe to be more inline with the existing options name ?
| @@ -190,7 +191,8 @@ protected function addWhere(QueryBuilder $queryBuilder, QueryNameGeneratorInterf | |||
| $queryBuilder->andWhere($baseWhere); | |||
| } elseif ( | |||
| (\in_array($operator, [self::PARAMETER_BEFORE, self::PARAMETER_STRICTLY_BEFORE], true) && self::INCLUDE_NULL_BEFORE === $nullManagement) || | |||
| (\in_array($operator, [self::PARAMETER_AFTER, self::PARAMETER_STRICTLY_AFTER], true) && self::INCLUDE_NULL_AFTER === $nullManagement) | |||
| (\in_array($operator, [self::PARAMETER_AFTER, self::PARAMETER_STRICTLY_AFTER], true) && self::INCLUDE_NULL_AFTER === $nullManagement) || | |||
| (\in_array($operator, [self::PARAMETER_AFTER, self::PARAMETER_STRICTLY_AFTER, self::PARAMETER_BEFORE, self::PARAMETER_STRICTLY_BEFORE], true) && self::ALWAYS_INCLUDE_NULL === $nullManagement) | |||
There was a problem hiding this comment.
Maybe invert the conditions as the === might have a lower cost ?
Simperfit
force-pushed
the
feature/add-always-include-null
branch
from
7cbce65
to
3695f5f
Compare
|
I'm not sure I understand the purpose of this. Aren't null values already included if you use one of |
|
Look at the linked issue: The OP wants to include null values always and it seems that doesn't work for now, so it's like a merge of both after and before so it will always includes null values. |
|
Uhh, yeah I just looked at the issue... Maybe call it |
|
done |
Simperfit
force-pushed
the
feature/add-always-include-null
branch
from
3695f5f
to
1375b2b
Compare
Simperfit
force-pushed
the
feature/add-always-include-null
branch
from
1375b2b
to
28bbbae
Compare
|
thanks @Simperfit |
Add a way to always include null values.