Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2115 SwaggerCommand with --yaml now properly serializes nested objects #2121

Merged
merged 1 commit into from
Sep 11, 2018

Conversation

dkarlovi
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #2115
License MIT

@dkarlovi dkarlovi changed the base branch from master to 2.3 July 23, 2018 07:00
@dkarlovi dkarlovi changed the title SwaggerCommand with --yaml now properly serializes nested objects bug: SwaggerCommand with --yaml now properly serializes nested objects Jul 23, 2018
@dkarlovi dkarlovi changed the title bug: SwaggerCommand with --yaml now properly serializes nested objects fix #2115 SwaggerCommand with --yaml now properly serializes nested objects Jul 23, 2018
@dkarlovi
Copy link
Contributor Author

CI failures unrelated.

@soyuka
Copy link
Member

soyuka commented Jul 25, 2018

Do you see a way we could test this? I guess not really but we never know :p.

@dkarlovi
Copy link
Contributor Author

Well sure, we add a sample couple of entities in the test suite and Swaggerize those? :)

@soyuka
Copy link
Member

soyuka commented Jul 25, 2018

would be great!

@dunglas dunglas merged commit b8bec07 into api-platform:2.3 Sep 11, 2018
@dunglas
Copy link
Member

dunglas commented Sep 11, 2018

Thanks @dkarlovi

@dkarlovi dkarlovi deleted the swagger-yaml-dump-object branch October 9, 2018 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants