Allow to use container parameters as class name #2233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't this be done at the metadata factory level? |
teohhanhui
reviewed
Oct 4, 2018
| /** | ||
| * Recursively replaces placeholders with the service container parameters. | ||
| * | ||
| * @see https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Routing/Router.php |
There was a problem hiding this comment.
theofidry
reviewed
Oct 4, 2018
| /** | ||
| * Base file extractor. | ||
| * | ||
| * @author Kévin Dunglas <dunglas@gmail.com> | ||
| */ | ||
| abstract class AbstractExtractor implements ExtractorInterface | ||
| { | ||
| private $container; |
There was a problem hiding this comment.
shouldn't private come after protected?
soyuka
approved these changes
Oct 5, 2018
soyuka
reviewed
Oct 5, 2018
| @@ -13,6 +13,10 @@ | |||
|
|
|||
| namespace ApiPlatform\Core\Metadata\Extractor; | |||
|
|
|||
| use Psr\Container\ContainerInterface; | |||
| use Symfony\Component\DependencyInjection\ContainerInterface as SymfonyContainerInterface; | |||
| use function array_key_exists; | |||
There was a problem hiding this comment.
mhh we're not doing this anywhere else?
There was a problem hiding this comment.
I think we should, it's way better than a leading backslash. That said it's better to apply a fixer for it so let's remove it here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to use a config like this one:
TODO: