Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return HTTP_CONFLICT 409 on Doctrine OptimisticLockException #2337

Merged
merged 1 commit into from
Nov 22, 2018
Merged

return HTTP_CONFLICT 409 on Doctrine OptimisticLockException #2337

merged 1 commit into from
Nov 22, 2018

Conversation

bendavies
Copy link
Contributor

@bendavies bendavies commented Nov 17, 2018 •
edited by dunglas
Loading

Q A
Bug fix? no
New feature? yes?
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets =
License MIT
Doc PR api-platform/docs#704

Seems like a nice sane default for Doctrine. thoughts?
I needed this in my API anyway.

@antograssiot
Copy link
Contributor

Seems a bit app specific to me ...

dunglas
dunglas requested changes Nov 18, 2018
View reviewed changes
Copy link
Member

@dunglas dunglas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me when the comment will be addressed. Indeed it is a bit specific, but it doesn't hurt, and having sane defaults is always a plus. WDYT @api-platform/core-team?

src/Bridge/Symfony/Bundle/DependencyInjection/Configuration.php Outdated Show resolved Hide resolved
@dunglas dunglas merged commit 28eb702 into api-platform:master Nov 22, 2018
@dunglas
Copy link
Member

dunglas commented Nov 22, 2018

Thanks @bendavies

@bendavies bendavies deleted the http-conflict branch November 22, 2018 15:29
@bendavies
Copy link
Contributor Author

thanks @dunglas

@dunglas dunglas mentioned this pull request Jan 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas approved these changes

@soyuka soyuka soyuka approved these changes

@soullivaneuh soullivaneuh soullivaneuh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bendavies @antograssiot @dunglas @soyuka @soullivaneuh