Always pass an array for AdvancedNameConverterInterface::normalize #2383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
soullivaneuh
commented
Dec 14, 2018
soullivaneuh
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #2382 |
| License | MIT |
| Doc PR |
soyuka
approved these changes
Dec 15, 2018
antograssiot
suggested changes
Dec 19, 2018
There was a problem hiding this comment.
@soullivaneuh as the initial PR #2344 was added to 2.3, I think that this fix should also target this branch.
it looks good otherwise 👍
|
target updated, the commit was based on the good branch, merging then. |
|
Oh right, sorry for the wrong branch selection, I did this PR too fast. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.