Fix version constraints for Doctrine MongoDB ODM #2466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpoulain
reviewed
Jan 21, 2019
alcaeus
force-pushed
the
fix-mongodb-odm-version-resolution
branch
from
7da751a
to
d78f5d9
Compare
alanpoulain
approved these changes
Jan 21, 2019
dunglas
approved these changes
Jan 25, 2019
|
For the record, I have no idea why the tests fail. Shouldn’t be related to this change 😉 |
|
@alcaeus can you please rebase ? tests have been fixed on 2.4 |
alanpoulain
force-pushed
the
fix-mongodb-odm-version-resolution
branch
from
d78f5d9
to
0ba9796
Compare
|
Thank you @alcaeus! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
composer.jsonwith aconflictconstraint for Doctrine MongoDB ODM. Since the ODM dependency is optional, usingconflictis the only way to enforce having 2.0 or later. Users with 1.0 will get weird errors about repositories not being of the expected type instead of a useful message that they should be using API Platform with 2.0 only.