Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decrease ApiGatewayNormalizer priority #2470

Merged
merged 7 commits into from
Jan 24, 2019
Merged

Decrease ApiGatewayNormalizer priority #2470

merged 7 commits into from
Jan 24, 2019

Conversation

vincentchalamon
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets api-platform/docs#722
License MIT
Doc PR

@vincentchalamon vincentchalamon self-assigned this Jan 23, 2019
dunglas
dunglas approved these changes Jan 23, 2019
View reviewed changes
Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add a non-regression test

@vincentchalamon
Copy link
Contributor Author

vincentchalamon commented Jan 23, 2019 •
edited
Loading

@BatsaxIV Could you check if it solves your issue, please? Otherwise, could you send me a scenario?

@BatsaxIV
Copy link

It's ok for me !

decoration-priority="-1" allows me to successfully decorate api_platform.swagger.normalizer.documentation

Thanks for the quick fix ;)

@vincentchalamon vincentchalamon merged commit a9bc507 into api-platform:master Jan 24, 2019
@vincentchalamon vincentchalamon deleted the issue/api-gateway-normalizer branch January 24, 2019 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas approved these changes

Assignees

@vincentchalamon vincentchalamon

Labels
bug [RFR] Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vincentchalamon @BatsaxIV @dunglas