Allow configuring input and ouput class per operation

[bendavies]

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets
License	MIT
Doc PR

This allows specifying the input and output class per operation.
It is already possibly to specify them for subresources, so I think it was an oversight for operations, which is why i'm classifying this as a bug.

[bendavies]

unrelated CI failure

[dunglas]

I don't really understand why we need that. It should already work actually

[bendavies]

I want to use a different DTO for creation and updating a resource. If you have a better idea I'm happy to hear it.

I couldn't get it to work at all per operation, without this PR.

[soyuka]

looks legit to me

[bendavies]

@soyuka is this the correct place to implement the fix?

[dunglas]

I don't understand why we need a request attribute for that. As the operation is known at this point, we should just be able to lookup the attribute value from the operation metadata (using the metadata factory). Or am I missing something?

[bendavies]

I'm not really sure, but this is where I traced to where input/output classes are set. Maybe @soyuka can comment as he is the author of the feature.
the original PR is here #2235

[dunglas]

The output class should be set directly on the @ApiResource annotation.
The following should already be supported:

/** @ApiResource(itemOperations={"get"={"output_class"="FooBar"}})*/

[bendavies]

Can you try?

I have tried exactly that, it does not work. here is my actually attempt:

/**
 * @ApiResource(
 *     normalizationContext={"groups": {"account:read"}},
 *     collectionOperations={
 *         "get": {"method": "GET", "path": "/accounts/"},
 *     },
 *     itemOperations={
 *         "get": {"output_class": "ThrowAnError", "method": "GET", "path": "/accounts/{id}", "requirements": {"id": "%uuid_regex%"}},
 *         "put": {"input_class": "ThrowAnError", "method": "PUT", "path": "/accounts/{id}", "requirements": {"id": "%uuid_regex%"}, "denormalization_context": {"groups": {"account:update"}}}
 *     }
 * )
 */

Which should throw an error, but does nothing. The config is ignored.

[soyuka]

@dunglas we were not using the operation configuration but rather the resource-level one:

https://github.com/soyuka/core/blob/cb5421abdb19392ac225909f63cf8677583cedd3/src/Bridge/Symfony/Routing/ApiLoader.php#L215-L216

Therefore, /** @ApiResource(itemOperations={"get"={"output_class"="FooBar"}})*/ is not supported yet, @ApiResource(input_class="") is though.

@bendavies yes the fix is in the correct place.

[dunglas]

The input class shouldn't be in the request attribute but in our own metadata We must change this behavior before tagging 2.4.

[bendavies]

Closing due to #2483