[GraphQL] Custom types #2492
Merged
[GraphQL] Custom types #2492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpoulain
commented
Feb 3, 2019
src/GraphQl/Type/SchemaBuilder.php
Outdated
| $this->graphqlTypes['Iterable'] = new IterableType(); | ||
| if ($this->typesFactory) { | ||
| $this->graphqlTypes += $this->typesFactory->getTypes(); | ||
| } else { |
There was a problem hiding this comment.
Should we remove this else or add a deprecation?
There was a problem hiding this comment.
IIRC this is still marked as Experimental no? I'd just keep the l81.
There was a problem hiding this comment.
I was asking this because of @dunglas's comment: #2447 (comment)
alanpoulain
force-pushed
the
graphql-custom-types
branch
from
2b88286
to
5dd0b91
Compare
|
@lukasluecke WDYT of this PR? |
soyuka
reviewed
Feb 6, 2019
| $tag['id'] = $serviceId; | ||
| } | ||
|
|
||
| $types[$tag['id']] = new Reference($serviceId); |
There was a problem hiding this comment.
Remove the isset line 37-39
Suggested change
| $types[$tag['id']] = new Reference($serviceId); | |
| $types[$tag['id'] ?? $serviceId] = new Reference($serviceId); |
|
@soyuka do you think we could merge this one? |
|
Can't merge because of travis :| |
alanpoulain
force-pushed
the
graphql-custom-types
branch
from
5dd0b91
to
bd186cf
Compare
alanpoulain
force-pushed
the
graphql-custom-types
branch
from
bd186cf
to
7331f27
Compare
|
Thanks @alanpoulain ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
TypeInterfaceto register automatically custom types in GraphQL.The
IterableTypehas been modified to be used this way.A
TypesFactoryservice has been added, along with its interface to allow to register custom types any way you want.Should we add a deprecation (see my comment below)?