Enable the pagination via cursor (no page-based pagination) #2532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
force-pushed
the
sroze-cursor-pagination
branch
3 times, most recently
from
215c084
to
dee63df
Compare
antograssiot
suggested changes
Feb 20, 2019
soyuka
force-pushed
the
sroze-cursor-pagination
branch
from
be4b2c0
to
832cc14
Compare
|
Doc pr : api-platform/docs#738 |
Add tests for the SoMany collection Uses the PropertyAccessor service and don't break the BC Allow to use multiple fields Fix cs Improve cursor-based pagination tests
soyuka
force-pushed
the
sroze-cursor-pagination
branch
from
832cc14
to
472609c
Compare
|
@soyuka We might still be missing something here that we were probably not doing back when the initial PR was open. I think we should add a |
|
Why this was not released in 2.4 ? 🙂 |
|
Because it did not land in 2.4 but in master, it's an experimental feature. |
|
Forgot about that lower branches are merged to master.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for the SoMany collection
Uses the PropertyAccessor service and don't break the BC
Allow to use multiple fields
Fix cs
To avoid breaking @sroze branch I'm creating a new PR with his work. Original PR is #1915 . I only rebased, squashed and fixed CS.