[GraphQL] Avoid to call serialize in ItemNormalizer #2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpoulain
force-pushed
the
graphql-avoid-serialize-normalizer
branch
2 times, most recently
from
3a8e28a
to
e3da7e6
Compare
soyuka
approved these changes
Mar 4, 2019
alanpoulain
force-pushed
the
graphql-avoid-serialize-normalizer
branch
from
e3da7e6
to
258f4a8
Compare
|
@alanpoulain , when this patch will be merged to release branch? |
|
@Siregacvek It'll be in |
|
@teohhanhui , well, it's better than in 2.6 :) |
CvekCoding
reviewed
May 26, 2019
| @@ -36,8 +36,8 @@ public function __construct(IriConverterInterface $iriConverter) | |||
| public function __invoke($source, $args, $context, ResolveInfo $info) | |||
| { | |||
| $property = null; | |||
| if ('id' === $info->fieldName && isset($source[ItemNormalizer::ITEM_KEY])) { | |||
There was a problem hiding this comment.
I think it's better to make 'id' and '_id' as consts of IndentifiersExtractor class.
CvekCoding
added a commit
to CvekCoding/core
that referenced
this pull request
May 26, 2019
CvekCoding
pushed a commit
to CvekCoding/core
that referenced
this pull request
May 26, 2019
* Avoid to call serialize in ItemNormalizer * Allow composite identifiers in getItemIriFromResourceClass (cherry picked from commit b3bd652)
CvekCoding
added a commit
to CvekCoding/core
that referenced
this pull request
May 26, 2019
…form#2576)" This reverts commit 90b8690
CvekCoding
pushed a commit
to CvekCoding/core
that referenced
this pull request
May 26, 2019
* Avoid to call serialize in ItemNormalizer * Allow composite identifiers in getItemIriFromResourceClass (cherry picked from commit b3bd652)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #2358.
Replace calls to serialize with computed data in the normalizer to improve performance.
In master because there are some BC breaks (but no deprecated since it's still experimental).