Use separate instance of ItemNormalizer for handling non-resource #2592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems it is a better way to do it indeed. |
This was referenced Mar 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2591, ...; alternative to #2566 (reverted here)This should ensure the same caching of
supports*methods as before for resource classes. For non-resource classes (handled by a separate instance), thesupports*methods use the$context, thus not cacheable.Not sure about the performance impact (positive or negative), but I think this is cleaner as we don't indiscriminately say yes to things we might not be able to handle (provided we're at a low enough priority). And there's no need for
use_api_platformand/or special treatment of some formats.Big thanks to @soyuka and @dunglas for the discussions and for bearing with me! 馃槤