Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure listeners are opt-in when not handling API Platform operations #2601

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Make sure listeners are opt-in when not handling API Platform operations #2601

merged 1 commit into from
Mar 12, 2019

Conversation

teohhanhui
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #2591
License MIT
Doc PR N/A

@teohhanhui teohhanhui mentioned this pull request Mar 11, 2019
Closed
@teohhanhui
Copy link
Contributor Author

PHPStan errors no longer present in v0.11.3 🎉

But in the meantime. Hmm...

@soyuka soyuka merged commit ddd0ca7 into api-platform:2.4 Mar 12, 2019
@soyuka
Copy link
Member

soyuka commented Mar 12, 2019

thanks @teohhanhui !

@teohhanhui teohhanhui deleted the fix/opt-in-listeners branch March 12, 2019 12:25
@bpolaszek
Copy link
Contributor

Got the same issue, checked out this commit, everything's fine now 👍

Thank you @teohhanhui ! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas approved these changes

@soyuka soyuka Awaiting requested review from soyuka

@meyerbaptiste meyerbaptiste Awaiting requested review from meyerbaptiste

@alanpoulain alanpoulain Awaiting requested review from alanpoulain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@teohhanhui @soyuka @bpolaszek @dunglas