[jsonapi][jsonhal] Correct normalization of output class and non-resource #2627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
teohhanhui
commented
Mar 19, 2019
•
teohhanhui
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | N/A |
| License | MIT |
| Doc PR | N/A |
teohhanhui
requested review from
dunglas,
soyuka,
meyerbaptiste,
antograssiot and
alanpoulain
teohhanhui
force-pushed
the
fix/jsonapi-normalize
branch
2 times, most recently
from
b99e23f
to
3b69049
Compare
soyuka
approved these changes
Mar 19, 2019
teohhanhui
force-pushed
the
fix/jsonapi-normalize
branch
from
3b69049
to
bac5205
Compare
teohhanhui
changed the title
teohhanhui
changed the title
teohhanhui
force-pushed
the
fix/jsonapi-normalize
branch
from
bac5205
to
05afcae
Compare
soyuka
approved these changes
Mar 19, 2019
|
Thanks @teohhanhui |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.