Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DX] Dockerfile and docker-compose #2787

Closed
wants to merge 1 commit into from

Conversation

alanpoulain
Copy link
Member

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

I'm using Docker for testing API Platform and I think it could be interesting to add it to API Platform to improve DX.

The image comes with MongoDB and XDebug.

It's complementary to #2703 because even if the tests are not run with MongoDB by default, if some tests related to MongoDB fail in Travis, you might need to run them locally.

WDYT?

@teohhanhui
Copy link
Contributor

I just use the Docker setup from api-platform/api-platform, and do (in the php container):

pecl install mongodb && docker-php-ext-enable mongodb

@teohhanhui
Copy link
Contributor

it could be interesting to add it to API Platform to improve DX

We should keep Dockerfiles in a separate repo if we want to have custom Docker images for running tests / builds. But there should be no docker-compose.yml.

Having them in this repo will create more confusion.

@alanpoulain
Copy link
Member Author

Having them in this repo will create more confusion.

I was thinking this too, that's why it's a proposal. I don't know, maybe if it's correctly explained it will not cause confusion.

@dunglas
Copy link
Member

dunglas commented May 15, 2019

I'm -1 too. Our skeleton and symfony/flex#128 should be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants