Fixed denormalization of a constructor argument which is a collection of non-resources

[karser]

Hi Folks!

After upgrading to 2.4.4 (from 2.4.2) I started getting an error.
The error wording is: The property path constructor needs a string or an instance of \"Symfony\\Component\\PropertyAccess\\PropertyPath\". Got: \"integer\" in symfony/serializer/Normalizer/AbstractObjectNormalizer.php, line 302.

I fixed this bug by adding '[]' to the class of the collection argument at this line.

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	PR adds the test case
License	MIT
Doc PR	api-platform/docs#1234

[soyuka]

Mhhh shouldn't this case go through the normalizeCollection few lines before?

[karser]

The few lines before case is for resource collection. It checks for isResourceClass. The case that I fixed with [] is apparently, for non-resource collection.
The createAttributeValue method was added in commit Fix ResourceClassResolver handling of inheritance. @teohhanhui Is this PR correct?

[teohhanhui]

Yes, you're right. The [] suffix is important for ArrayDenormalizer. I'll check soon.

[teohhanhui]

@karser You need to to do the same for the corresponding class mapped as MongoDB Document: https://github.com/api-platform/core/blob/v2.4.4/tests/Fixtures/TestBundle/Document/DummyEntityWithConstructor.php

[karser]

@teohhanhui done. MongoDB documents reuse behat features, don't they?

[teohhanhui]

Hmm... Not sure why the same test for mongodb is still failing. I'll investigate.

[teohhanhui]

Yikes. Looks like we're expecting the same order for the JSON keys, which is nonsensical.

[karser]

Not fully following and it's not evident what you changed. I added $items in the corresponding places in the entity and document. If test passes for the entity, the order of json keys in the output shouldn't be different for the document.

[teohhanhui]

It's because you added the getItems method in a different order in the document compared to the entity, so.... 🙈

[karser]

I see now, ugh!

[karser]

Just wondering, since the entities and documents must be 100% identical, wouldn't it make sense to use the same classes and move the orm and odm annotations to xml files?

[teohhanhui]

Thanks @karser! 🎉 🚀