Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused trait import #2882

Merged
merged 1 commit into from
Jun 26, 2019
Merged

Remove unused trait import #2882

merged 1 commit into from
Jun 26, 2019

Conversation

norkunas
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@soyuka soyuka merged commit 2ca416b into api-platform:2.4 Jun 26, 2019
@soyuka
Copy link
Member

soyuka commented Jun 26, 2019

Thanks @norkunas !

@norkunas norkunas deleted the cleanup branch June 26, 2019 12:35
@teohhanhui
Copy link
Contributor

teohhanhui commented Jun 26, 2019 •
edited
Loading

Hmm... Were php-cs-fixer and phpstan not able to catch this?

@norkunas
Copy link
Contributor Author

norkunas commented Jun 26, 2019 •
edited
Loading

Hmm... Were php-cs-fixer and phpstan not able to catch this?

PHPStan when running locally:

[ERROR] Found 5828 errors

but this could be because i've ran composer install --ignore-platform-reqs because of mongo

@teohhanhui
Copy link
Contributor

teohhanhui commented Jun 26, 2019 •
edited
Loading

Yes, you need mongodb extension to run phpstan. It's the reason why I've added the Doctrine MongoDB ODM packages back to require-dev, because installing the extension is easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@norkunas @soyuka @teohhanhui