Merge 2.4 into master #3038
Merged
Merge 2.4 into master #3038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alanpoulain
commented
Sep 2, 2019
alanpoulain
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | N/A |
| License | MIT |
| Doc PR | N/A |
Fix the failing build
[MINOR] PHPDoc Typo
teohhanhui
approved these changes
Sep 2, 2019
alanpoulain
force-pushed
the
merge-2.4
branch
from
5b1a880
to
4bf6c83
Compare
teohhanhui
reviewed
Sep 2, 2019
|
symfony/symfony#33450 (comment) Let's fix it here then. |
bpolaszek
pushed a commit
to alanpoulain/core
that referenced
this pull request
Sep 4, 2019
bpolaszek
pushed a commit
to alanpoulain/core
that referenced
this pull request
Sep 4, 2019
bpolaszek
pushed a commit
to alanpoulain/core
that referenced
this pull request
Sep 4, 2019
teohhanhui
reviewed
Sep 4, 2019
bpolaszek
pushed a commit
to alanpoulain/core
that referenced
this pull request
Sep 4, 2019
bpolaszek
pushed a commit
to alanpoulain/core
that referenced
this pull request
Sep 4, 2019
teohhanhui
suggested changes
Sep 4, 2019
alanpoulain
force-pushed
the
merge-2.4
branch
from
384b74c
to
a3b7383
Compare
alanpoulain
pushed a commit
to alanpoulain/core
that referenced
this pull request
Sep 5, 2019
alanpoulain
force-pushed
the
merge-2.4
branch
from
a3b7383
to
68cb7e1
Compare
teohhanhui
added a commit
to alanpoulain/core
that referenced
this pull request
Sep 5, 2019
Co-authored-by: Teoh Han Hui <teohhanhui@gmail.com>
teohhanhui
force-pushed
the
merge-2.4
branch
from
68cb7e1
to
2708733
Compare
Co-authored-by: Teoh Han Hui <teohhanhui@gmail.com>
teohhanhui
force-pushed
the
merge-2.4
branch
from
2708733
to
b0cd959
Compare
|
Thanks @alanpoulain, @bpolaszek ! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.