Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

non-int value in the execute command will be deprecated #3152

Merged
merged 1 commit into from
Oct 5, 2019
Merged

non-int value in the execute command will be deprecated #3152

merged 1 commit into from
Oct 5, 2019

Conversation

maxhelias
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Related to symfony/symfony#33775

We can already apply this change without BC
It was the only command in this case

@alanpoulain
Copy link
Member

Why not in 2.5?

@maxhelias
Copy link
Contributor Author

Yes, I will change

@maxhelias maxhelias changed the base branch from master to 2.5 October 5, 2019 13:22
@soyuka soyuka merged commit 3a648f2 into api-platform:2.5 Oct 5, 2019
@soyuka
Copy link
Member

soyuka commented Oct 5, 2019

Thanks @maxhelias

@maxhelias maxhelias deleted the deprecated-console branch October 5, 2019 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanpoulain alanpoulain alanpoulain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maxhelias @alanpoulain @soyuka