Fix support for custom filters without constructor in ApiFilter annotation #3166
+261
−141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
LouisPinsard
commented
Oct 11, 2019
•
LouisPinsard
commented
| Q | A |
|---|---|
| Bug fix? | yes/ |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #3049 |
| License | MIT |
| Doc PR |
soyuka
approved these changes
Oct 11, 2019
teohhanhui
previously requested changes
Oct 11, 2019
src/Bridge/Symfony/Bundle/DependencyInjection/Compiler/AnnotationFilterPass.php
Outdated
Show resolved
Hide resolved
teohhanhui
reviewed
Oct 11, 2019
LouisPinsard
force-pushed
the
allow-api-filter-without-construct
branch
3 times, most recently
from
a910f1b
to
3d14da7
Compare
|
Hello @teohhanhui I modified the PR with your return if you can take a look ! |
soyuka
approved these changes
Oct 18, 2019
teohhanhui
force-pushed
the
allow-api-filter-without-construct
branch
from
3d14da7
to
87a0cef
Compare
teohhanhui
force-pushed
the
allow-api-filter-without-construct
branch
from
87a0cef
to
724ac49
Compare
teohhanhui
changed the title
soyuka
approved these changes
Oct 18, 2019
|
thanks @teohhanhui @LouisPinsard ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.