Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add date interval to type factory #3351

Merged
merged 1 commit into from Feb 18, 2020

Conversation

soyuka
Copy link
Member

@soyuka soyuka commented Jan 20, 2020

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tickets na
License MIT
Doc PR api-platform/docs#...

Add the DateInterval class as duration in json schemas

@dunglas
Copy link
Member

dunglas commented Jan 21, 2020

Isn't this a new feature?

@teohhanhui
Copy link
Contributor

I think this is a bug fix because we were missing the special handling for \DateInterval, which led to #3343 (even though the behaviour observed there was probably caused by #3349).

@teohhanhui
Copy link
Contributor

Needs rebase.

@soyuka soyuka force-pushed the fix/json-schema-date-interval branch from e307415 to cb8eff7 Compare February 18, 2020 14:19
@teohhanhui teohhanhui merged commit a59af14 into api-platform:2.5 Feb 18, 2020
@teohhanhui
Copy link
Contributor

Thanks @soyuka! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants